-
Notifications
You must be signed in to change notification settings - Fork 6.7k
[modular] add auto_docstring & more doc related refactors #12958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
7b499de
up
yiyixuxu b29873d
up up
yiyixuxu fbfe5c8
Merge branch 'main' into modular-doc-improv
yiyixuxu 43ab148
update outputs
yiyixuxu 34a743e
style
yiyixuxu ff09bf1
add modular_auto_docstring!
yiyixuxu d20f413
more auto docstring
yiyixuxu 2a81f2e
style
yiyixuxu f0555af
up up up
yiyixuxu 507953f
more more
yiyixuxu 1c90ce3
up
yiyixuxu aea0d04
address feedbacks
yiyixuxu 25c968a
add TODO in the description for empty docstring
yiyixuxu de03d7f
refactor based on dhruv's feedback: remove the class method
yiyixuxu 002c3e8
add template method
yiyixuxu 1f2dbc9
up
yiyixuxu fb15752
up up up
yiyixuxu 8d45ff5
apply auto docstring
yiyixuxu f056af1
make style
yiyixuxu 9452520
rmove space in make docstring
yiyixuxu 7e9d2b9
Apply suggestions from code review
yiyixuxu b7127ce
revert change in z
yiyixuxu d75fbc4
Merge branch 'modular-doc-improv' of github.com:huggingface/diffusers…
yiyixuxu 1f9576a
fix
yiyixuxu aba551c
Merge branch 'main' into modular-doc-improv
yiyixuxu 23d0642
Apply style fixes
github-actions[bot] 412e51c
include auto-docstring check in the modular ci. (#13004)
sayakpaul cf22044
Run ruff format after auto docstring generation
yiyixuxu 517d8f8
up
yiyixuxu 437a8c5
upup
yiyixuxu 389bed1
upup
yiyixuxu b409750
style
yiyixuxu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
our pipeline parameter are pretty consistent across different pipelines, e.g. you always have
prompt,height,width,num_inference_steps, etc. I made template for these common ones, so that it is easier to definebefore you need
now you do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit apprehensive about introducing dedicated class methods for common parameters in this way. I think the class can become quite large as common inputs expand.
I would prefer to keep current syntax (IMO this ensures InputParams are defined in a consistent way) and use post init on the dataclass to automatically add a description. e.g
If we feel that methods for these inputs are necessary, one way to address it without adding individual methods to the InputParam is to use a metaclass. It would result in the InputParam object being less crowded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the class methods!
also moved the common parameter definitions out of
InputParam/OutputParamas well. They're currently still in the same file, but we can move them elsewhere later.To use a predefined param:
i went with this API, instead of the
__post_init__because you have to explicitly opt into using the template, even though it's slightly more verbose.The main thing I wanted to avoid is with
__post_init__auto-filling, if you make a param that exists in our template but actually intend to customize its docstring later, e.g. you do something likeInputParam(name="image"), you will silently get the template defaults, and it is hard to notice.With
.template(), it's more clear when the user intends to use the pre-defined definition vs write a custom param. so for the same example, if someone writesInputParam(name="image")without filling in fields, the docstring will show "TODO: Add description".we can also override fields in the template like this: