[bug fix] GLM-Image fit new get_image_features API#13052
Merged
yiyixuxu merged 2 commits intohuggingface:mainfrom Jan 30, 2026
Merged
[bug fix] GLM-Image fit new get_image_features API#13052yiyixuxu merged 2 commits intohuggingface:mainfrom
get_image_features API#13052yiyixuxu merged 2 commits intohuggingface:mainfrom
Conversation
Signed-off-by: JaredforReal <w13431838023@gmail.com>
Contributor
Author
|
tested and works fine, @yiyixuxu PTAL, thanks! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GLM-Image pipeline to maintain compatibility with transformers V5, which changed the API for GlmImageForConditionalGeneration.get_image_features(). The method no longer accepts return_dict as an explicit parameter, and callers must now access the .pooler_output attribute from the returned object.
Changes:
- Modified
get_image_features()call to removereturn_dict=Falseparameter and access.pooler_outputattribute instead - Updated image feature extraction for image-to-image mode to work with transformers V5 API
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
Author
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upstream transformers upgraded to V5, and
GlmImageForConditionalGeneration.get_image_features()won't takereturn_dictas an explicit arg.Downstream Caller is recommended to pass
return_dict=Trueand use.pooler_outputto adapt to V5 transformersFixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.