Skip to content

Add semantic guidance pipeline #2223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Feb 17, 2023
Merged

Add semantic guidance pipeline #2223

merged 20 commits into from
Feb 17, 2023

Conversation

manuelbrack
Copy link
Contributor

Add new pipeline for semantic guidance as introduced in SEGA: Instructing Diffusion using Semantic Dimensions

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Feb 2, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

patrickvonplaten
patrickvonplaten reviewed Feb 3, 2023
View reviewed changes
src/diffusers/pipelines/semantic_stable_diffusion/pipeline_semantic_stable_diffusion.py Outdated
super().__init__()

if hasattr(scheduler.config, "steps_offset") and scheduler.config.steps_offset != 1:
deprecation_message = (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the deprecation statement - not needed for new models :-)

@patrickvonplaten
Copy link
Contributor

PR looks great, only two small recommendations for correction :-)

Also could you add a new doc page here:
https://github.com/huggingface/diffusers/tree/main/docs/source/en/api/pipelines
And some quick tests here:
https://github.com/huggingface/diffusers/tree/main/tests/pipelines

Thanks a lot!

@patrickvonplaten patrickvonplaten mentioned this pull request Feb 3, 2023
Closed
@patrickvonplaten
Copy link
Contributor

Looks great! Think now just some short tests are missing :-)

@manuelbrack
Copy link
Contributor Author

Looks great! Think now just some short tests are missing :-)

@PatrickSchrML is already working on it ;)

@manuelbrack manuelbrack requested review from patrickvonplaten and removed request for williamberman February 13, 2023 11:31
@manuelbrack
Copy link
Contributor Author

manuelbrack commented Feb 13, 2023 •
edited
Loading

Tests are also implemented now :D

patrickvonplaten
patrickvonplaten approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! @williamberman can you give it a final review?

@manuelbrack @patrickvonplaten
Update src/diffusers/pipelines/semantic_stable_diffusion/pipeline_sem…
771c78d 
…antic_stable_diffusion.py

Co-authored-by: Patrick von Platen <[email protected]>
manuelbrack and others added 9 commits February 16, 2023 13:52
@patrickvonplaten patrickvonplaten merged commit 01a8080 into huggingface:main Feb 17, 2023
@patrickvonplaten patrickvonplaten deleted the semantic-guidance branch February 17, 2023 14:54
mengfei25 pushed a commit to mengfei25/diffusers that referenced this pull request Mar 27, 2023
@manuelbrack @patrickvonplaten @mengfei25
Add semantic guidance pipeline (huggingface#2223)
8a538f3 
* Add semantic guidance pipeline

* Fix style

* Refactor Pipeline

* Pipeline documentation

* Add documentation

* Fix style and quality

* Fix doctree

* Add tests for SEGA

* Update src/diffusers/pipelines/semantic_stable_diffusion/pipeline_semantic_stable_diffusion.py

Co-authored-by: Patrick von Platen <[email protected]>

* Update src/diffusers/pipelines/semantic_stable_diffusion/pipeline_semantic_stable_diffusion.py

Co-authored-by: Patrick von Platen <[email protected]>

* Update src/diffusers/pipelines/semantic_stable_diffusion/pipeline_semantic_stable_diffusion.py

Co-authored-by: Patrick von Platen <[email protected]>

* Make compatible with half precision

* Change deprecation warning to throw an exception

* update

---------

Co-authored-by: Patrick von Platen <[email protected]>
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@manuelbrack @patrickvonplaten
Add semantic guidance pipeline (huggingface#2223)
4aee722 
* Add semantic guidance pipeline

* Fix style

* Refactor Pipeline

* Pipeline documentation

* Add documentation

* Fix style and quality

* Fix doctree

* Add tests for SEGA

* Update src/diffusers/pipelines/semantic_stable_diffusion/pipeline_semantic_stable_diffusion.py

Co-authored-by: Patrick von Platen <[email protected]>

* Update src/diffusers/pipelines/semantic_stable_diffusion/pipeline_semantic_stable_diffusion.py

Co-authored-by: Patrick von Platen <[email protected]>

* Update src/diffusers/pipelines/semantic_stable_diffusion/pipeline_semantic_stable_diffusion.py

Co-authored-by: Patrick von Platen <[email protected]>

* Make compatible with half precision

* Change deprecation warning to throw an exception

* update

---------

Co-authored-by: Patrick von Platen <[email protected]>
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
@manuelbrack @patrickvonplaten
Add semantic guidance pipeline (huggingface#2223)
27e8b12 
* Add semantic guidance pipeline

* Fix style

* Refactor Pipeline

* Pipeline documentation

* Add documentation

* Fix style and quality

* Fix doctree

* Add tests for SEGA

* Update src/diffusers/pipelines/semantic_stable_diffusion/pipeline_semantic_stable_diffusion.py

Co-authored-by: Patrick von Platen <[email protected]>

* Update src/diffusers/pipelines/semantic_stable_diffusion/pipeline_semantic_stable_diffusion.py

Co-authored-by: Patrick von Platen <[email protected]>

* Update src/diffusers/pipelines/semantic_stable_diffusion/pipeline_semantic_stable_diffusion.py

Co-authored-by: Patrick von Platen <[email protected]>

* Make compatible with half precision

* Change deprecation warning to throw an exception

* update

---------

Co-authored-by: Patrick von Platen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickvonplaten patrickvonplaten patrickvonplaten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manuelbrack @HuggingFaceDocBuilderDev @patrickvonplaten