Skip to content

explicit broadcasts for assignments #3535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2023
Merged

explicit broadcasts for assignments #3535

merged 1 commit into from
May 24, 2023

Conversation

williamberman
Copy link
Contributor

Fixing more errors from assignments with explicit broadcasts

FAILED tests/pipelines/stable_diffusion_2/test_stable_diffusion_latent_upscale.py::StableDiffusionLatentUpscalePipelineFastTests::test_cpu_offload_forward_pass - RuntimeError: linearIndex.numel()*sliceSize*nElemBefore == expandedValue.numel() INTERNAL ASSERT FAILED at "../aten/src/ATen/native/cuda/Indexing.cu":389, please report a bug to PyTorch. number of flattened indices did not match number of elements in the value tensor: 512 vs 16

@williamberman williamberman requested review from pcuenca, yiyixuxu, sayakpaul and patrickvonplaten and removed request for pcuenca May 23, 2023 20:55
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 23, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

pcuenca
pcuenca approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! Did assignment stop working at some point?

patrickvonplaten
patrickvonplaten approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

@patrickvonplaten patrickvonplaten merged commit db56f8a into huggingface:main May 24, 2023
@williamberman
Copy link
Contributor Author

@pcuenca I think it only happens when determinism is turned on and even then not every time, it's a really weird bug that I didn't dig into past that

yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@williamberman
explicit broadcasts for assignments (huggingface#3535)
7753c9e
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
@williamberman
explicit broadcasts for assignments (huggingface#3535)
cf49375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcuenca pcuenca pcuenca approved these changes

@sayakpaul sayakpaul sayakpaul approved these changes

@patrickvonplaten patrickvonplaten patrickvonplaten approved these changes

@yiyixuxu yiyixuxu Awaiting requested review from yiyixuxu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@williamberman @HuggingFaceDocBuilderDev @pcuenca @sayakpaul @patrickvonplaten