Set minimum supported Rust version to 1.71.1#58
Open
tiran wants to merge 1 commit intohuggingface:mainfrom
Open
Set minimum supported Rust version to 1.71.1#58tiran wants to merge 1 commit intohuggingface:mainfrom
tiran wants to merge 1 commit intohuggingface:mainfrom
Conversation
Add `rust-version` to Cargo.toml to ensure that `cargo` from Rust >= 1.83 does not bump `Cargo.lock` to file format v4. 1.71.1 is oldest Rust toolchain that can compile the package and its dependencies: * package `writeable v0.5.5` cannot be built because it requires rustc 1.67 or newer * package `mio v1.0.3` cannot be built because it requires rustc 1.70 or newer * package `zerofrom v0.1.5` cannot be built because it requires rustc 1.71.1 or newer GHA tests are now building+testing with minimum version and latest stable version of the Rust toolchain. Fixes: huggingface#55 Signed-off-by: Christian Heimes <christian@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
rust-versionto Cargo.toml to ensure thatcargofrom Rust >= 1.83 does not bumpCargo.lockto file format v4. 1.71.1 is oldest Rust toolchain that can compile the package and its dependencies:writeable v0.5.5cannot be built because it requires rustc 1.67 or newermio v1.0.3cannot be built because it requires rustc 1.70 or newerzerofrom v0.1.5cannot be built because it requires rustc 1.71.1 or newerGHA tests are now building+testing with minimum version and latest stable version of the Rust toolchain.
Fixes: #55