Skip to content

Remove outputs to enable Github rendering #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Rocketknight1
Copy link
Member

@Rocketknight1 Rocketknight1 commented Apr 22, 2025

This PR uses jupyter nbconvert --clear-output --inplace on our notebook files - some of them were saved with outputs, which went out of date and no longer render properly in GitHub.

Fixes #566

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Rocketknight1
Copy link
Member Author

cc @NielsRogge since you were in the original issue - are you okay with the change?

Copy link
Contributor

@NielsRogge NielsRogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's a bit of a bummer, so Github does not allow to see outputs anymore of Jupyter notebooks?

@Rocketknight1
Copy link
Member Author

I think the problem is that the outputs included widget state, but the widget state became old and no longer matched the modern versions of those widgets, so GitHub wasn't able to render it anymore.

A short-term fix is to remove notebook outputs, but we could also have someone rerun all of the notebooks with modern jupyter and re-save them, which should allow them to render on GitHub again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid Notebook *.ipynb files.
2 participants