Skip to content

Conversation

@AlexanderDokuchaev
Copy link
Contributor

@AlexanderDokuchaev AlexanderDokuchaev commented Aug 4, 2023

Changes

  • Fix incorrect format of openvino/stable-diffusion/requirements.txt
  • Change argument name of Accelerator from logging_dir to project_dir, logging_dir deprecated since 0.18
  • Remove second call accelerator.prepare for unet

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 4, 2023

The documentation is not available anymore as the PR was closed or merged.

@AlexKoff88
Copy link
Contributor

As far as I understood model export gets broken after this change so it needs to be fixed before merging this.

Copy link
Contributor

@fxmarty fxmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I can't test those changes as I get an error at this point

for _, batch in tqdm(zip(range(args.opt_init_steps), itertools.islice(dataloader, 0, args.opt_init_steps))):
in the script, telling me that the collate_fn from the dataloader is not pickable. Have you had the issue @AlexKoff88 ?

@@ -1,5 +1,5 @@
accelerate
diffusers
torch~=1.13
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything blocking for pytorch 2.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not check it.

@AlexKoff88
Copy link
Contributor

Thank you!

I can't test those changes as I get an error at this point

for _, batch in tqdm(zip(range(args.opt_init_steps), itertools.islice(dataloader, 0, args.opt_init_steps))):

in the script, telling me that the collate_fn from the dataloader is not pickable. Have you had the issue @AlexKoff88 ?

I am looking into it. There are multiple issues introduced by updates in transformers and accelerate libraries. Need to highly refactor the script.

@AlexKoff88
Copy link
Contributor

Some issues in this PR should be fixed after merging this PR: #397

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants