Support transformers 4.53 and SmolLM3#22
Merged
Conversation
… both optimum and optimum-onnx
justinchuby
reviewed
Jul 17, 2025
justinchuby
reviewed
Jul 17, 2025
justinchuby
reviewed
Jul 17, 2025
| # "optimum~=1.26", | ||
| # "optimum~=1.27", | ||
| "optimum @ git+https://github.com/huggingface/optimum.git@mv-onnx", | ||
| "transformers>=4.36,<4.53.0", |
Collaborator
There was a problem hiding this comment.
For my knowledge: what is the policy for supporting transformers versions? When can be drop support for an old version?
Member
Author
There was a problem hiding this comment.
tbh I'm not sure, I also believe that we should drop some versions because transformers has changed so much.
maybe keeping 10 or 12 versions since there's one transformers release every month ? @echarlaix
justinchuby
approved these changes
Jul 17, 2025
IlyasMoutawwakil
changed the title
justinchuby
reviewed
Jul 17, 2025
justinchuby
reviewed
Jul 17, 2025
| # This is a workaround for the Qwen3 Moe Sparse block that is not compatible with ONNX export. | ||
| # The forward method of the Moe Sparse block is patched to avoid looping only on the experts that are selected | ||
| # by the router, which fails during execution in ONNX Runtime. | ||
| # TODO: investigate more on this issue. |
Collaborator
There was a problem hiding this comment.
Maybe helpful to create tracking issues and link them here?
Collaborator
|
Is this ready to merge? |
Member
Author
|
@justinchuby not yet, there new changes in optimum's PR that I need to bring here. should be updated and merged today ! |
…dows rmtree problem
Member
Author
|
@justinchuby I will merge once slow tests pass |
justinchuby
added a commit
that referenced
this pull request
Jul 23, 2025
Import from future to leverage the latest style for python typing annotations, and make import more efficient. Depends on #22 --------- Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Co-authored-by: IlyasMoutawwakil <moutawwakil.ilyas.tsi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
same as huggingface/optimum#2319