Update ort CIs (slow, gpu, train)#2024
Merged
Merged
Conversation
3 tasks
IlyasMoutawwakil
added
onnxruntime-gpu
and removed
training
gpu-test
IlyasMoutawwakil
added
onnxruntime-training
onnxruntime-slow
and removed
training
labels
echarlaix
approved these changes
Jan 21, 2025
Collaborator
echarlaix
left a comment
echarlaix
left a comment
There was a problem hiding this comment.
Thanks a lot for the great PR @IlyasMoutawwakil !
| ) | ||
| self.state.is_hyper_param_search = trial is not None | ||
| self.state.train_batch_size = self._train_batch_size | ||
|
|
Collaborator
There was a problem hiding this comment.
also cc @JingyaHuang who took care of the ort training integrations
echarlaix
reviewed
Jan 27, 2025
IlyasMoutawwakil
force-pushed
the
enable-ort-gpu-tests
branch
from
0be7883 to
696cc95
Compare
IlyasMoutawwakil
force-pushed
the
enable-ort-gpu-tests
branch
from
eedff54 to
881015c
Compare
| "accelerate", # ORTTrainer requires it. | ||
| "transformers>=4.36,<4.49.0", | ||
| ], | ||
| "onnxruntime-training": [ |
Member
Author
There was a problem hiding this comment.
The readme and docs should reflect this change
Collaborator
|
Thanks a lot @IlyasMoutawwakil for adding many fixes ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a PR that fixes:
I tried my best to make things work with the least change, in some cases that was hard, e.g. io binding was dependant on the input order in the forward signature, which made some model types incompatible with the ORTModel signature.
Before submitting
Who can review?