[fix] Allow ORTQuantizer over models with subfolder ONNX files#2094
Merged
echarlaix merged 3 commits intoNov 18, 2024
Conversation
echarlaix
approved these changes
Nov 18, 2024
Collaborator
echarlaix
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix @tomaarsen !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
Pull Request overview
Details
Currently, if you call
ORTQuantizerover a model that was loaded with asubfolder, then it'll break:There are 2 issues at play:
from_pretrainedAutoConfig.from_pretrainedfails, it often fails with aValueErrorrather than an OSError..An underlying issue is that #2044 added/strengthened the "ONNX in subfolders" support by allowing the config to be in root while the model is in a subfolder - the ORTQuantizer wasn't updated to reflect that the config.json isn't necessarily adjacent to the
model.onnx.FYI, this is breaking https://sbert.net/docs/package_reference/util.html#sentence_transformers.backend.export_dynamic_quantized_onnx_model in some cases.
Before submitting
Who can review?
@echarlaix as you added/strengthened the "ONNX in subfolders" support & that's how I encountered this.