Skip to content

Pass the revision to SentenceTransformer models#2105

Merged
echarlaix merged 1 commit into
huggingface:mainfrom
bndos:feat/pass-revision-to-st
Nov 28, 2024
Merged

Pass the revision to SentenceTransformer models#2105
echarlaix merged 1 commit into
huggingface:mainfrom
bndos:feat/pass-revision-to-st

Conversation

@bndos
Copy link
Copy Markdown
Contributor

@bndos bndos commented Nov 27, 2024

What does this PR do?

Ensures that the revision parameter is passed to SentenceTransformer models in get_model_from_task.

@bndos bndos marked this pull request as draft November 27, 2024 22:16
@bndos bndos marked this pull request as ready for review November 27, 2024 22:17
Copy link
Copy Markdown
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @bndos !

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@echarlaix echarlaix merged commit 28bd0ad into huggingface:main Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants