Conversation
Comment on lines
974
to
+977
| def test_load_model_from_hub_private(self): | ||
| token = os.environ.get("HF_HUB_READ_TOKEN", None) | ||
|
|
||
| if token is None: | ||
| if not token: |
Member
There was a problem hiding this comment.
There's a require_hf_token decorator in https://github.com/huggingface/optimum/blob/main/optimum/utils/testing_utils.py#L88
it's used in some places but it checks for HF_AUTH_TOKEN instead of HF_HUB_READ_TOKEN 🤔 should we use that decorator instead ?
Collaborator
Author
There was a problem hiding this comment.
Here the issue seems that the token is set as an empty string instead of being set to None (so the same issue will happen for require_hf_token). Let's see if this fixes it, in which case I'll update require_hf_token
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/huggingface/optimum/actions/runs/12406440330/job/34639615964?pr=2114