fix sdxl refiner export#2133
Merged
Merged
Conversation
Contributor
Author
|
@echarlaix @IlyasMoutawwakil could you please take a look? |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Collaborator
|
It should have been caught by the CI, we need to add a test for this (looks like |
Member
|
Yes the refiner architecture totally went over my head, thank for the fix @eaidova. Feel free to add a test in this PR or I'll add it in another one. |
Member
|
Merging for the transformers 4.47 support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
after some refactoring export part, sdxl-refiner model become broken for exporting.
https://huggingface.co/stabilityai/stable-diffusion-xl-refiner-1.0
This model does not have text_encoder and only text_encoder_2, now export failed with AtributeError: 'NoneType' object has no attribute 'config'
see for reference https://github.com/huggingface/optimum-intel/actions/runs/12426942003/job/34696091118?pr=1085