Skip to content

ExporterConfig refactorization#2157

Merged
echarlaix merged 31 commits into
mainfrom
onnx
Jun 18, 2025
Merged

ExporterConfig refactorization#2157
echarlaix merged 31 commits into
mainfrom
onnx

Conversation

@echarlaix
Copy link
Copy Markdown
Collaborator

@echarlaix echarlaix commented Jan 15, 2025

The different exporters configs (ONNXConfig, TFLiteConfig, NeuronExportConfig) which all are subclass of ExportersConfig share a lot of different attributes and methods

@echarlaix echarlaix force-pushed the onnx branch 2 times, most recently from fd11cd0 to cf9a51d Compare January 17, 2025 14:42
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@echarlaix echarlaix marked this pull request as ready for review February 12, 2025 16:59
@echarlaix echarlaix changed the title Add ExportersConfig ExporterConfig refactorization Feb 12, 2025
self._preprocessors = preprocessors
self._normalized_config = self.NORMALIZED_CONFIG_CLASS(self._config)
self.variant = "default"
self._preprocessors = preprocessors
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be moved to the base config as well (the way i see it is that information about the model is sometimes scattered across config and preprocessors)

Comment thread optimum/exporters/base.py
@echarlaix echarlaix requested a review from JingyaHuang June 12, 2025 14:05
Copy link
Copy Markdown
Member

@IlyasMoutawwakil IlyasMoutawwakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@echarlaix echarlaix merged commit be76dde into main Jun 18, 2025
34 checks passed
@echarlaix echarlaix deleted the onnx branch June 18, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants