Skip to content

Add onnx export for efficientnet#2214

Merged
echarlaix merged 5 commits into
huggingface:mainfrom
Thas-Tayapongsak:add-onnx-export-for-efficientnet
Apr 24, 2025
Merged

Add onnx export for efficientnet#2214
echarlaix merged 5 commits into
huggingface:mainfrom
Thas-Tayapongsak:add-onnx-export-for-efficientnet

Conversation

@Thas-Tayapongsak
Copy link
Copy Markdown
Contributor

What does this PR do?

I added an onnx config class for efficientnet models. I tested it according to https://huggingface.co/docs/optimum/exporters/onnx/usage_guides/contribute on tiny random models and it passed, but for larger one like google/efficientnet-b7 it did not pass the atol.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

@fxmarty, @echarlaix, @JingyaHuang, @michaelbenayoun

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@IlyasMoutawwakil
Copy link
Copy Markdown
Member

@Thas-Tayapongsak please resolve conflicts (rebase or merge main)

@Thas-Tayapongsak
Copy link
Copy Markdown
Contributor Author

I'm not very familiar with git yet but I see a green checkmark, so I hope what I did is correct.

@IlyasMoutawwakil
Copy link
Copy Markdown
Member

Doesn't look right 🫠 The code changes went crazy, you should do:

git ferch
git merge main
*resolve conflicts if any*
git push

@Thas-Tayapongsak
Copy link
Copy Markdown
Contributor Author

😬 my bad. I'll try again

@Thas-Tayapongsak
Copy link
Copy Markdown
Contributor Author

I did it. seems better than last time

Copy link
Copy Markdown
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the addition @Thas-Tayapongsak !

@echarlaix echarlaix merged commit fa87c66 into huggingface:main Apr 24, 2025
32 of 38 checks passed
@Thas-Tayapongsak Thas-Tayapongsak deleted the add-onnx-export-for-efficientnet branch April 25, 2025 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants