Add onnx export for efficientnet#2214
Merged
echarlaix merged 5 commits intoApr 24, 2025
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
|
@Thas-Tayapongsak please resolve conflicts (rebase or merge main) |
Contributor
Author
|
I'm not very familiar with git yet but I see a green checkmark, so I hope what I did is correct. |
Member
|
Doesn't look right 🫠 The code changes went crazy, you should do: |
Contributor
Author
|
😬 my bad. I'll try again |
Contributor
Author
|
I did it. seems better than last time |
echarlaix
approved these changes
Apr 24, 2025
Collaborator
There was a problem hiding this comment.
LGTM, thanks for the addition @Thas-Tayapongsak !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I added an onnx config class for efficientnet models. I tested it according to https://huggingface.co/docs/optimum/exporters/onnx/usage_guides/contribute on tiny random models and it passed, but for larger one like google/efficientnet-b7 it did not pass the atol.
Before submitting
Who can review?
@fxmarty, @echarlaix, @JingyaHuang, @michaelbenayoun