[Gemma3] Add supported tasks and normalized config#2345
Closed
simondanielsson wants to merge 2 commits into
Closed
[Gemma3] Add supported tasks and normalized config#2345simondanielsson wants to merge 2 commits into
simondanielsson wants to merge 2 commits into
Conversation
simondanielsson
force-pushed
the
feature/add-gemma3-export
branch
from
262a819 to
e9f5bdd
Compare
simondanielsson
commented
Sep 3, 2025
| "gpt_neo": NormalizedTextConfig.with_args(num_attention_heads="num_heads"), | ||
| "gpt_neox": NormalizedTextConfig, | ||
| "gptj": GPT2LikeNormalizedTextConfig, | ||
| "granite": NormalizedTextConfigWithGQA, |
Author
There was a problem hiding this comment.
Explanation: this one was out of place
simondanielsson
commented
Sep 3, 2025
|
|
||
| Gemma3NormalizedTextAndVisionConfig = create_normalized_text_and_vision_config( | ||
| text_config_cls=Gemma3NormalizedTextConfigWithGQA | ||
| ).with_args(text_config="text_config", vision_config="vision_config") |
Author
There was a problem hiding this comment.
Note: Happy to hear if you have a cleaner way of doing this :)
simondanielsson
changed the title
simondanielsson
force-pushed
the
feature/add-gemma3-export
branch
from
7afb702 to
f82dafd
Compare
3 tasks
Member
|
Hi, the addition of model types in the tasks manager is no longer necessary, same thing for normalized configs, as we are trying to make optimum-subpackages less dependent on optimum during development. I will close this PR and let's discuss the caveats in your PR there 🤗 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds supported tasks and normalized config for Gemma3, to support exporting Gemma3 models.
Accompanied PR here.
Fixes huggingface/optimum-onnx#49 (issue)
Before submitting
Who can review?
@echarlaix, @JingyaHuang, @michaelbenayoun, @IlyasMoutawwakil