Fix bug about accessing model.config when model is None in pipeline#301
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
4 tasks
philschmid
approved these changes
Jul 18, 2022
Contributor
philschmid
left a comment
There was a problem hiding this comment.
LGTM. Nice that you reused the transformer's things of doing it. ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the issue mentioned in #297: when instantiating a pipeline with
pipe = pipeline(task=my_task), the givenmodelisNoneand we get the following error:With this PR,
model.configis not accessed anymore to setload_tokenizerandload_feature_extractor. Tests have been added to automatically check this behaviour.Also:
pipelinemethod from Transformers intests/onnxruntime/test_modeling.py, this is changed for thepipelinemethod of Optimum.Before submitting