Fixes for ORT 1.13.1#430
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
| mode=quantization_config.mode, | ||
| weight_qType=quantization_config.weights_dtype, | ||
| input_qType=quantization_config.activations_dtype, | ||
| activation_qType=quantization_config.activations_dtype, |
There was a problem hiding this comment.
In order for us to support onnxruntime version lower than 1.13.1, could you adapt the quantizer_factory behavior depending on which onnxruntime version is used ?
There was a problem hiding this comment.
You're absolutely right, I just added it!
|
Thank you very much @regisss! Especially since opimization is currently not working for me because of this missing field: Does anybody know a workaround or should I just wait for the patch? Will it be also cherry picked into 1.3.1 or only directly to 1.4.1? Thanks! |
|
Hi @nmaoez! If you need the fix ASAP, the best is to install Optimum from source as follows: git clone https://github.com/huggingface/optimum.git
cd optimum/
pip install .[onnxruntime]A patch is coming very soon but I don't know if this will be integrated to it. Maybe @echarlaix can tell more about this. |
|
@echarlaix Amazing! Thanks! |
What does this PR do?
This PR fixes a couple of errors that appeared with ORT 1.13.1:
disable_shape_inferenceis added toOptimizationConfigsince it has been added toFusionOptionsin ORT (see Add --disable_shape_inference option to optimizer.py microsoft/onnxruntime#12215),input_qTypebyactivation_qTypeinquantization.pysince this argument name has changed in ORT (see Splitting quantize_tensor and quantize_input microsoft/onnxruntime#12873).Before submitting