add a asdict for dataclass model_config #2641
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
get_model_config
function intuners_utils.py
does not handle model_config of dataclass data type, because some models (such as the lerobot model) haveconfig
attributes, but the dataclass type cannot be converted into a dictionary in theget_model_config function
, resulting in an error when using.get
in the_get_tied_target_modules
function.I fixed this problem. Make peft adapt to a wider range of model types.