Update no-stop-sequence model list to support gpt-5.2* #1895
Conversation
| ipython_config.py | ||
|
|
||
| # pyenv | ||
| # .python-version |
There was a problem hiding this comment.
If the lines are commented, tthenhey are currently ignored.
Apart form the one duplicated, why not just uncommenting the others?
src/smolagents/models.py
Outdated
| openai_model_pattern = r"(o3[-\d]*|o4-mini[-\d]*|gpt-5(-mini|-nano)?[-\d]*|gpt-5.1[-\d]*)" | ||
| grok_model_pattern = r"([a-zA-Z]+\.)?(grok-3-mini|grok-4|grok-code-fast)(-[A-Za-z0-9]*)?" | ||
| # o3*, o4*, all grok-* models, and the gpt-5* family (including versioned variants) don't support stop parameter | ||
| openai_model_pattern = r"(o3(?:$|[-.].*)|o4(?:$|[-.].*)|gpt-5(?:$|[-.].*))" |
There was a problem hiding this comment.
Making this more future-proof to also support gpt-5.3 and next ones when they are released.
Same for grok.
albertvillanova
left a comment
albertvillanova
left a comment
There was a problem hiding this comment.
Thanks. Just a question below.
tests/test_models.py
Outdated
| [ | ||
| # Unsupported base models | ||
| ("o3", False), | ||
| ("o3-mini", False), |
There was a problem hiding this comment.
"o3-mini" (as others, like "o4" and "o4-turbo") was before True, and now it is False. Why? Which value is the right one?
| ipython_config.py | ||
|
|
||
| # pyenv | ||
| # .python-version |
There was a problem hiding this comment.
If the lines are commented, tthenhey are currently ignored.
Apart form the one duplicated, why not just uncommenting the others?
|
Ok I've manually retested Grok and OpenAI models: here is the answer to the question: does this model support a
Also one thing to note: claude models used to go |
No description provided.