Handle Qwen 3 chat template #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Nice bro, you're awesome.🥰🥰🥰 |
Collaborator
Okay, got your suggestion. Is it this option?
|
Collaborator
Author
|
Yes. And I verified that this fixes the error with Qwen 3. |
Collaborator
|
LGTM！Nice👍 Is it possible to add Qwen3 Template test cases? |
Collaborator
Author
|
Done. |
johnmai-dev
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds methods used in the Qwen 3 chat template, which were previously missing from this library.
@johnmai-dev, to keep the commit history of this repo clean, I suggest using the squash on merge strategy (you can configure it in the repo's settings on GitHub). Currently there's a separate merge commit for each merged PR.