Skip to content

Add tilde operator #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DePasqualeOrg wants to merge 2 commits into from
Closed

Add tilde operator #18

DePasqualeOrg wants to merge 2 commits into from

Conversation

@DePasqualeOrg
Copy link
Collaborator

@DePasqualeOrg DePasqualeOrg commented Jul 9, 2025

I still need to add a test for the SmolLM3 chat template.

@johnmai-dev
Copy link
Collaborator

johnmai-dev commented Jul 9, 2025

You are truly outstanding.🚀🚀🚀

pcuenca
pcuenca reviewed Jul 9, 2025
View reviewed changes
Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@johnmai-dev johnmai-dev linked an issue Jul 9, 2025 that may be closed by this pull request
Parse error on SmolLM3 chat template #17
Closed
@DePasqualeOrg
Copy link
Collaborator Author

DePasqualeOrg commented Jul 9, 2025

I added a test, but when I run it I get this error: testSmolLM3(): failed: caught error: "parser("Parser Error: Expected closing statement token. identifier != closeStatement.")

I need to leave it here for now, but maybe you can figure out what's going wrong.

@DePasqualeOrg
Copy link
Collaborator Author

DePasqualeOrg commented Jul 9, 2025 •
edited
Loading

The problem seems to be Swift Jinja's handling of escaped quotation marks here:

{%- set xml_tool_string = ns.xml_tool_string + "</tools>\n\nFor each function call, return a json object with function name and arguments within <tool_call></tool_call> XML tags:\n<tool_call>\n{\"name\": <function-name>, \"arguments\": <args-json-object>}\n</tool_call>" -%}

I am not able to take on the task of fixing this separate problem, but others are welcome to do that.

If you want to try to fix it with agentic tools, I recommend cloning https://github.com/pallets/jinja inside this repo so that it can be used for reference.

@johnmai-dev johnmai-dev mentioned this pull request Jul 10, 2025
Merged
johnmai-dev added a commit that referenced this pull request Jul 10, 2025
@johnmai-dev @DePasqualeOrg
Add tilde operator By @DePasqualeOrg #18 (#19)
fc1233d 
* Add tilde operator

* Add test for SmolLM3

* Fix tilde operator handling to use additive binary operator

* Add testSmolLM3FromHF

* swift-format

* Add replace function to String extension with optional count parameter

* Add unit tests for String replacingOccurrences function

* Add test for SmolLM3 template rendering with system prompt

* swift-format

---------

Co-authored-by: Anthony DePasquale <[email protected]>
@DePasqualeOrg
Copy link
Collaborator Author

DePasqualeOrg commented Jul 21, 2025

@johnmai-dev, it would have made more sense to work with my original PR instead of creating a new one using my commits. I will close this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcuenca pcuenca pcuenca left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Parse error on SmolLM3 chat template

3 participants

@DePasqualeOrg @johnmai-dev @pcuenca