Add some backwards-compatible getters #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pcuenca Looks really good! CI is only failing due to 429. |
|
I didn't have time to dig into this, so no notes. I'll test it in ml-explore/mlx-swift-examples#322 once it's merged. |
TL;DR: you will be able to keep using |
|
Great, ml-explore/mlx-swift-examples#322 builds with no errors using the latest commit of swift-transformers. Would you like to create a new version tag? Then I can update the dependency in mlx-swift-examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, we can't provide a
dictionaryvar because the symbol has been replaced withdictionary()now :(Even so, I think this could be useful for many downstream users, I don't think the use of
dictionaryis too frequent.What are your thoughts @FL33TW00D, @DePasqualeOrg?