Skip to content

fix: fix 210 #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 2, 2025
Merged

fix: fix 210 #211

merged 5 commits into from
Aug 2, 2025

Conversation

FL33TW00D
Copy link
Collaborator

@FL33TW00D FL33TW00D commented Jul 30, 2025

Explanation #210 (comment)

Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!

Why did it trigger so many format changes? We've had several PRs added after swift format was introduced.

@FL33TW00D
Copy link
Collaborator Author

swiftformat is a moving target and reinstall every CI run :(

@FL33TW00D
Copy link
Collaborator Author

429 in CI for tests.

@pcuenca
Copy link
Member

pcuenca commented Aug 1, 2025

Tests pass locally. How do you feel about merging the two pending PRs while we deal with the CI, @FL33TW00D?

@FL33TW00D
Copy link
Collaborator Author

@pcuenca happy to do it! Will merge the pinning first, then fix this branch and merge it

@pcuenca
Copy link
Member

pcuenca commented Aug 1, 2025

Awesome! I opened huggingface/hf-workflows#38 to try to fix the CI 🤞

@pcuenca
Copy link
Member

pcuenca commented Aug 2, 2025

Merging anyway.

@pcuenca pcuenca merged commit 65418e4 into main Aug 2, 2025
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants