Skip {% generation %} and {% endgeneration %} template handling#3204
Merged
Skip {% generation %} and {% endgeneration %} template handling#3204
{% generation %} and {% endgeneration %} template handling#3204Conversation
Custom syntax within the chat template for the Phi4 Reasoning models e.g. https://huggingface.co/microsoft/Phi-4-reasoning-plus, which is AFAIK not handled natively yet, so skipping for now
Narsil
reviewed
May 1, 2025
This reverts commit d64d6d2.
Member
|
This will work fine in a lot of cases, but will fail to catch syntax like |
Member
Author
Thanks! I'll make sure to update it to handle that properly rather than a raw replacement 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is just a tentative fix for both
{% generation %}and{% endgeneration %}custom syntax introduced within some chat templates for returning a mask of the assistant generated tokens which is only useful during training and should indeed be ignored during inference, affecting models as e.g.microsoft/Phi-4-reasoning-plus.Thanks to @Rocketknight1 for the explanation!
Before submitting
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@Narsil