Skip to content

fix(server): Adding logger import to t5_modeling.py#585

Merged
OlivierDehaene merged 1 commit intohuggingface:mainfrom
akowalsk:patch-1
Jul 12, 2023
Merged

fix(server): Adding logger import to t5_modeling.py#585
OlivierDehaene merged 1 commit intohuggingface:mainfrom
akowalsk:patch-1

Conversation

@akowalsk
Copy link
Contributor

Logger is referenced during the apex importing but is not imported, causing a NameError

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Logger is referenced during the apex importing but is not imported, causing a NameError
@OlivierDehaene OlivierDehaene changed the title Adding logger import to t5_modeling.py fix(server): Adding logger import to t5_modeling.py Jul 12, 2023
Copy link
Contributor

@OlivierDehaene OlivierDehaene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@OlivierDehaene OlivierDehaene merged commit 7f90722 into huggingface:main Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants