Skip to content

Fix exllama wronfully loading#990

Merged
Narsil merged 3 commits intohuggingface:mainfrom
maximelaboisson:fix_exllama_wronfully_loading
Sep 7, 2023
Merged

Fix exllama wronfully loading#990
Narsil merged 3 commits intohuggingface:mainfrom
maximelaboisson:fix_exllama_wronfully_loading

Conversation

@maximelaboisson
Copy link
Contributor

@maximelaboisson maximelaboisson commented Sep 7, 2023

What does this PR do?

The changes disabling exllama on old compute had unintended consequences of not setting use_exllama to False if HAS_EXLLAMA equals False and CAN_EXLLAMA equals False. This fixes this.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@OlivierDehaene @Narsil

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Contributor

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot !

@Narsil Narsil merged commit 935a77f into huggingface:main Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants