Skip to content

Fixed slow tokenizer behavior to make it remove special tokens when asked #23312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixed slow tokenizer behavior to make it remove special tokens when asked #23312

wants to merge 1 commit into from

Conversation

pedrogengo
Copy link
Contributor

What does this PR do?

Fixes #23250

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@amyeroberts
Copy link
Collaborator

cc @ArthurZucker

@pedrogengo
Copy link
Contributor Author

I still need to do some more tests, but the idea is just add the special in the special tokens list. I will work more on it in this week :)

@ArthurZucker
Copy link
Collaborator

Hey! Thanks for working on this and good luck haha! Ping me if you need any help on fixing the tests.
I think that the core bug is gonna be bit tricky to get right, but it should be fixed

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot closed this Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skip_special_tokens has different behavior between slow and fast tokenizer
4 participants