Add InternLM2 model and tests#29667
Conversation
|
amazing!!! |
ArthurZucker
left a comment
There was a problem hiding this comment.
Hey! Thanks for porting this model, is the only different with the Llama arch the non splitted QKV? If so, you have the Persimmon architecture that should be compatible out of the box with weight renaming!
What about the tokenizer, pretty sure the first InternLM used LlamaTokenizer converted by @Rocketknight1 no?
Thanks for your reply!
|
|
Regarding 1. There is a Llama like model with fused QKV in |
These were what you recommended to do:
Is that right? |
|
Yes! I falcon only relies on a for 1. I can have another look to check what is the closest model to help, pretty sure it's persimmon (merge qkv) and phi (split qkv) |
Thanks! I will try For |
|
|
|
Hi @x54-729, just checking out if you are still planning to finish this PR. Feel free to ask me any question =) |
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
|
I would like to bump / reopen this. I am trying to run a ray serve deployment with internlm2_5: and keep running into issues that this exact PR would solve: |
|
This PR was never finished so the integration you are doing relies on remote code |
What does this PR do?
All the tests have passed locally except some tokenizer issues(#29617, #29626). These failed tests are skipped temporarily.
I'm not very sure that my code format and tests are proper enough to merge, if there are any changes neede,d please let me know and I will fix them asap!
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ArthurZucker