Repository navigation
Conversation
ArthurZucker
left a comment
ArthurZucker
left a comment
Collaborator
There was a problem hiding this comment.
Looks super complicated, thanks for diving!
Just missing some doc for me 🤗
LysandreJik
reviewed
Oct 18, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ydshieh
requested review from
ArthurZucker
and removed request for
ArthurZucker
October 28, 2024 10:28
ArthurZucker
approved these changes
Oct 28, 2024
ArthurZucker
left a comment
ArthurZucker
left a comment
Collaborator
There was a problem hiding this comment.
Okay, on my side I don't really see how this can be "hacked" now, sys.executable is supposed to be safe, we could also just put python here no?
Collaborator
Author
|
On some docker environment we use, |
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
* check * check * check * check * add docstring --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In order to make
running (some individual) tests in a subprocesswork with GPU (cuda), if we usemultiprocessing, we have to usespawn, but this uses pickle and has some limitations that make the necessary changes to the test methods quite big.This PR tries to use the
subprocessmodule to implement a simpler way to run (some individual) tests in a subprocess.