Repository navigation
fix incorrect warning - #34416
Merged
Merged
fix incorrect warning#34416
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
molbap
approved these changes
Oct 28, 2024
molbap
left a comment
molbap
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the fix! I ought to do some documentation for how the kwargs merging logic works - the logic flow is a bit tricky indeed
LysandreJik
approved these changes
Oct 28, 2024
LysandreJik
left a comment
LysandreJik
left a comment
Member
There was a problem hiding this comment.
Nice! Feel free to merge when ready
yonigozlan
force-pushed
the
fix-incorrect-warning
branch
from
October 28, 2024 18:00
0d03c2e to
de9f91c
Compare
Contributor
Author
|
Tests are failing for unrelated (I think) reasons |
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follows this PR #34285
The warnings are displayed for all kwargs not in common, even if they are used in other modalities.
This PR only changes the logic of the warning, the kwargs handling logic should already be correct.
Who can review?
Cc @molbap , sorry I think you may have hinted at this problem previously but I did not pick up on it.