Skip to content

update doc - #34478

Merged
stevhliu merged 4 commits into
huggingface:mainfrom
jiqing-feng:doc
Oct 31, 2024
Merged

stevhliu merged 4 commits into
huggingface:mainfrom
jiqing-feng:doc

Conversation

@jiqing-feng

Copy link
Copy Markdown
Contributor

Update CPU doc

@Rocketknight1

Copy link
Copy Markdown
Member

cc @stevhliu

@stevhliu stevhliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating! Feel free to mark as ready whenever you're ready :)

Comment thread docs/source/en/perf_train_cpu.md Resolved
Check more approaches for [oneccl_bind_pt installation](https://github.com/intel/torch-ccl).
Versions of oneCCL and PyTorch must match.

<Tip warning={true}>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to also delete the closing </Tip> tag

jiqing-feng and others added 2 commits October 31, 2024 08:46
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@jiqing-feng
jiqing-feng marked this pull request as ready for review October 31, 2024 00:52
@jiqing-feng

Copy link
Copy Markdown
Contributor Author

Hi @stevhliu . Thanks for your review. I have fixed all the comments, now it's ready to merge :)

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu stevhliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🤗

@stevhliu
stevhliu merged commit 2801d7b into huggingface:main Oct 31, 2024
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
* update doc

* Update docs/source/en/perf_train_cpu.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* delete closing tip

---------

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@jiqing-feng
jiqing-feng deleted the doc branch December 19, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants