[tests] make cuda-only tests device-agnostic #35222
Merged
Merged
Conversation
Member
|
cc @ydshieh |
Collaborator
|
LGTM, but is still in draft mode or ready to go? |
Contributor
Author
Yes, we are ready to go. |
Collaborator
|
@Rocketknight1 Maybe we can merge once you approved? |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
|
This seems significant enough that it might need a core maintainer! cc @LysandreJik @ArthurZucker |
Collaborator
|
I talked to ArthurZucker offline and we agree that I have some level of permissions to merge PRs like this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently this test is restricted to run on CUDA, but it can also run on other accelerators like XPU.