Whisper: fix static cache CI #35852
Merged
Whisper: fix static cache CI #35852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurZucker
approved these changes
Jan 23, 2025
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Nice that the slack ping worked!
gante
reviewed
Jan 29, 2025
Contributor
gante
left a comment
gante
left a comment
There was a problem hiding this comment.
In general LGTM, but I have a question
| input_features = input_features.to(torch_device) | ||
| eager_generated_ids = model.generate(input_features, max_new_tokens=64) | ||
|
|
||
| # Using statiic cache compiles forward for each decoding step, so we don't have to manually compile |
Contributor
There was a problem hiding this comment.
Suggested change
| # Using statiic cache compiles forward for each decoding step, so we don't have to manually compile | |
| # Using static cache compiles forward for each decoding step, so we don't have to manually compile |
gante
approved these changes
Jan 29, 2025
Member
Author
|
Merging after tests are fixed on |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This was referenced Feb 3, 2025
Closed
bursteratom
pushed a commit
to bursteratom/transformers
that referenced
this pull request
Feb 5, 2025
* fix * remove overriden method * small change
elvircrn
pushed a commit
to elvircrn/transformers
that referenced
this pull request
Feb 13, 2025
* fix * remove overriden method * small change
sbucaille
pushed a commit
to sbucaille/transformers
that referenced
this pull request
Feb 16, 2025
* fix * remove overriden method * small change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Some tests started failing after #35164. This PR fixes it by:
_sampleprepare_inputs_for_generationRan tests:
pytest -k greedy tests/models(moshi is failing even onmain)pytest tests/models/whisper/test_modeling_whisper.py