Update composition flag usage #36263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
Author
|
cc @ydshieh this should solve the quick fix we did a few day ago :) |
Collaborator
ArthurZucker
approved these changes
Apr 8, 2025
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Makes sense! Not sure if I see breaking but it is cleaning up after our sub config updates!
cyr0930
pushed a commit
to cyr0930/transformers
that referenced
this pull request
Apr 18, 2025
* update composition flag usage * remove print * fix tests * actually fix * oh c'mon * now should be fixed right? * fix copies
zucchini-nlp
added a commit
to zucchini-nlp/transformers
that referenced
this pull request
May 14, 2025
* update composition flag usage * remove print * fix tests * actually fix * oh c'mon * now should be fixed right? * fix copies
lenglaender
added a commit
to lenglaender/adapters
that referenced
this pull request
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Actual fix for #36230. The very first PR that added the flag wasn't what we want, since the root cause of Pixtra config reloading is not in nested configs. The cause is how Mistral config is written with a
Nonehead-dim which is later inferred fromhidden_dim. Bug from #36048 can be reproduced by reloading only the mistral configTL;DR; We can't do that because the modeling code has no assumption about
hidden_size = head_dim * num_heads. So the solution is to set thehead dimonly when config has the value, otherwise it will get inferred during modeling attentionAlso, this PR renames the flag which is very misleading in its name. The flag was first added for models like RAG, when the config can't be init without args. The flag therefore is used only once, when trying to get default values of the config class (if any). Renaming shouldn't break BC I believe