-
Notifications
You must be signed in to change notification settings - Fork 31.7k
[smolvlm] make CI green #36306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[smolvlm] make CI green #36306
Conversation
zucchini-nlp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
|
We're also getting lots of CI failures because all of the processor tests for SmolVLM depend on |
|
Sorry, didn't notice it would fail. Actually the package is used only when chatting with video, so we might raise error only when |
|
@zucchini-nlp at the end of the day, would fail too: either we have no tests for the feature, or we need to push the new requirement :D I'm leaving that part of the logic changes to you 🤗 And I agree, the check should only exist where it is strictly needed |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Yep, we can later raise error only when video code is called. But making |
|
Note: CI images being built here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I just realized that the file have to be changed is
docker/torch-light.dockerfile
(see slack message for more details)
molbap
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Processors seems green now!
|
CI images pushed in the |
What does this PR do?
num2wordsrequirement