Skip to content

Added handling for length <2 of suppress_tokens for whisper #36336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gante merged 3 commits into from
Feb 25, 2025
Merged

Added handling for length <2 of suppress_tokens for whisper #36336

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1cc2320
Update generation_whisper.py
andreystarenky Feb 21, 2025
b8bccdd
Updated None check for suppress_tokens to avoid ambiguity
andreystarenky Feb 21, 2025
6f53aa0
Merge branch 'main' into suppress-tokens-length-catch
gante Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/transformers/models/whisper/generation_whisper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1779,7 +1779,10 @@ def _prepare_decoder_input_ids(

prev_start_of_text = getattr(generation_config, "prev_sot_token_id", None)
if prev_start_of_text is None:
prev_start_of_text = suppress_tokens[-2] if suppress_tokens is not None else None
if suppress_tokens is not None and len(suppress_tokens) >= 2:
prev_start_of_text = suppress_tokens[-2]
else:
prev_start_of_text = None

if any(do_condition_on_prev_tokens) and len(current_segments[0]) > 0:
# according to https://github.com/openai/whisper/blob/e58f28804528831904c3b6f2c0e473f346223433/whisper/decoding.py#L609
Expand Down