-
Notifications
You must be signed in to change notification settings - Fork 31.7k
[generate] torch.distributed-compatible DynamicCache
#36373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@S1ro1 it should be okay now 👌 |
|
@gante Comments look good to me, maybe small nit would be writing down the shapes? i.e. |
BenjaminBossan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this, LGTM.
|
(merging to unblock PEFT) |
What does this PR do?
DynamicCachewas not compatible withtorch.distributedbefore, and #36212 exposed the issue. See the discussion starting here for more details. The added code contains comments explaining what's going on.Fixes
Trainer+ DP whenuse_cache=True, such as in prefix tuning training runs.