[CLI] add import guards #36376
Merged
[CLI] add import guards #36376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gante
added
the
for patch
gante
commented
Feb 24, 2025
| _gptqmodel_available = _is_package_available("gptqmodel") | ||
| # `importlib.metadata.version` doesn't work with `awq` | ||
| _auto_awq_available = importlib.util.find_spec("awq") is not None | ||
| _quanto_available = _is_package_available("quanto") |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Rocketknight1
approved these changes
Feb 25, 2025
Member
Rocketknight1
left a comment
Rocketknight1
left a comment
There was a problem hiding this comment.
Yes, LGTM and thanks for the quick fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #36244
The introduction of
transformers-cli chatcaused ANY cli call to depend ontorchandrich, both optional requirements. This PR adds the appropriate import guards -- tested against a fresh venv withpip install -e .(no extras).@Rocketknight1 we don't have tests for commands 👀 I'm going to defer it for now, as we probably need to review our commands for v5.