Fix dtype when loading to meta model #36447
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before #36335, when loading the weights to meta model we kept the
dtypeof the module params. This PR fixes it by settingassign=True. I am not sure though, whystrict=False, should I change it toTrue?Before (no
dtypeis passed to accelerate):set_module_tensor_to_device(model, param_name, param_device, **set_module_kwargs)After:
module.load_state_dict({param_type: param[:].to(param_device)}, False, True)