Fix loading zero3 weights #36455
Merged
Fix loading zero3 weights #36455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the |
SunMarc
reviewed
Feb 27, 2025
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Nice thanks, can go in integration no? (integration/deepspeed)
SunMarc
approved these changes
Feb 27, 2025
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
shethaadit
approved these changes
Feb 27, 2025
Member
|
when is this gonna be merged ? |
ArthurZucker
approved these changes
Feb 28, 2025
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Nice thanks for iterating!
Member
|
thanks @muellerzr |
Contributor
Author
|
Yeah @ArthurZucker needs to merge it b/c of failings :) |
garrett361
pushed a commit
to garrett361/transformers
that referenced
this pull request
Mar 4, 2025
* Check if fixes * Fix zero3 loading * Quality * Fix marc nit * Add fast tests * Migrate to integrations.deepspeed rather than modeling_utils * Style
garrett361
pushed a commit
to garrett361/transformers
that referenced
this pull request
Mar 4, 2025
* Check if fixes * Fix zero3 loading * Quality * Fix marc nit * Add fast tests * Migrate to integrations.deepspeed rather than modeling_utils * Style
github-merge-queue bot
pushed a commit
to deepspeedai/DeepSpeed
that referenced
this pull request
Mar 27, 2025
Reverts #7085 which pinned the transformers version due to likely breaking changes from huggingface/transformers#36335, fixes introduced in huggingface/transformers#36455 Error: ``` RuntimeError: Failed to import transformers.models.vision_encoder_decoder.modeling_vision_encoder_decoder because of the following error (look up to see its traceback) ``` ``` FAILED unit/runtime/zero/test_zero_nesting_init.py::TestNestedParallelInit::test_nested_parallel_init - RuntimeError: Error(s) in loading state_dict for VisionEncoderDecoderModel: ``` After these changes, we still see errors on some tests with all_close --------- Signed-off-by: Logan Adams <[email protected]>
github-merge-queue bot
pushed a commit
to deepspeedai/DeepSpeed
that referenced
this pull request
Mar 27, 2025
Reverts #7085 which pinned the transformers version due to likely breaking changes from huggingface/transformers#36335, fixes introduced in huggingface/transformers#36455 Error: ``` RuntimeError: Failed to import transformers.models.vision_encoder_decoder.modeling_vision_encoder_decoder because of the following error (look up to see its traceback) ``` ``` FAILED unit/runtime/zero/test_zero_nesting_init.py::TestNestedParallelInit::test_nested_parallel_init - RuntimeError: Error(s) in loading state_dict for VisionEncoderDecoderModel: ``` After these changes, we still see errors on some tests with all_close --------- Signed-off-by: Logan Adams <[email protected]>
github-merge-queue bot
pushed a commit
to deepspeedai/DeepSpeed
that referenced
this pull request
Mar 28, 2025
Reverts #7085 which pinned the transformers version due to likely breaking changes from huggingface/transformers#36335, fixes introduced in huggingface/transformers#36455 Error: ``` RuntimeError: Failed to import transformers.models.vision_encoder_decoder.modeling_vision_encoder_decoder because of the following error (look up to see its traceback) ``` ``` FAILED unit/runtime/zero/test_zero_nesting_init.py::TestNestedParallelInit::test_nested_parallel_init - RuntimeError: Error(s) in loading state_dict for VisionEncoderDecoderModel: ``` After these changes, we still see errors on some tests with all_close --------- Signed-off-by: Logan Adams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#36335 broke zero3 weight loading because we can't do TP for it and it needs to be how the methods were done originally.
Related fixings: #36441
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@ArthurZucker @SunMarc