Skip to content

Conversation

@Rocketknight1
Copy link
Member

The tokenizer from_pretrained code has a dead code path (a list that is never appended to), so this PR removes it!

@github-actions github-actions bot marked this pull request as draft February 27, 2025 18:06
@github-actions
Copy link
Contributor

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the Ready for review button (at the bottom of the PR page).

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@gante gante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Rocketknight1 Rocketknight1 force-pushed the remove_unused_from_pretrained_code branch from 27d6733 to 93688e3 Compare March 3, 2025 17:38
@Rocketknight1 Rocketknight1 marked this pull request as ready for review March 3, 2025 17:44
@Rocketknight1 Rocketknight1 force-pushed the remove_unused_from_pretrained_code branch from 93688e3 to 26fdacc Compare March 3, 2025 18:18
@Rocketknight1 Rocketknight1 merged commit 6aa9888 into main Mar 3, 2025
24 checks passed
@Rocketknight1 Rocketknight1 deleted the remove_unused_from_pretrained_code branch March 3, 2025 18:31
garrett361 pushed a commit to garrett361/transformers that referenced this pull request Mar 4, 2025
garrett361 pushed a commit to garrett361/transformers that referenced this pull request Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants