[Style] fix E721 warnings #36474
Merged
[Style] fix E721 warnings #36474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Rocketknight1
approved these changes
Feb 28, 2025
Member
Rocketknight1
left a comment
Rocketknight1
left a comment
There was a problem hiding this comment.
LGTM! ping me whenever you're finished and I'll merge (and try rerunning the tests or rebasing to get rid of those CI errors)
Contributor
Author
|
i am good! |
shethaadit
approved these changes
Feb 28, 2025
Rocketknight1
force-pushed
the
warning-style
branch
from
0fd45b1 to
b744d09
Compare
Member
|
@kashif sorry for the failing tests - we merged a PR that fixes them and I did a rebase! |
garrett361
pushed a commit
to garrett361/transformers
that referenced
this pull request
Mar 4, 2025
* fix E721 warnings * config.hidden_size is not a tuple * fix copies * fix-copies * not a tuple * undo * undo
garrett361
pushed a commit
to garrett361/transformers
that referenced
this pull request
Mar 4, 2025
* fix E721 warnings * config.hidden_size is not a tuple * fix copies * fix-copies * not a tuple * undo * undo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix E721 Use
isandis notfor type comparisons and do not printconfig.hidden_sizeas a tuple.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.