Fix kwargs UserWarning in SamImageProcessor #36479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
transformers/image_processing_utils.py:41: UserWarning: The following named arguments are not valid for `SamImageProcessor.preprocess` and were ignored: 'point_pad_value'
Contributor
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the |
Contributor
|
Thanks for the PR @MSt-10! |
Contributor
|
run-slow: sam |
Contributor
|
This comment contains run-slow, running the specified jobs: This comment contains run-slow, running the specified jobs: models: ['models/sam'] |
qubvel
approved these changes
Mar 3, 2025
garrett361
pushed a commit
to garrett361/transformers
that referenced
this pull request
Mar 4, 2025
transformers/image_processing_utils.py:41: UserWarning: The following named arguments are not valid for `SamImageProcessor.preprocess` and were ignored: 'point_pad_value'
garrett361
pushed a commit
to garrett361/transformers
that referenced
this pull request
Mar 4, 2025
transformers/image_processing_utils.py:41: UserWarning: The following named arguments are not valid for `SamImageProcessor.preprocess` and were ignored: 'point_pad_value'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a user warning when using the SamProcessor.
The SamProcessorKwargs contain the argument
point_pad_valuebut this is only needed by the SamProcessor and not by the SamImageProcessor, hence a warning is generated when calling the SamImageProcessor here.I removed the argument from the dictionary similarly to how e.g.
input_pointsare handled since they are also not needed by the SamImageProcessor.Who can review?
@qubvel