Fix pipeline+peft interaction #36480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rocketknight1
force-pushed
the
pipeline-peft-interaction-fix
branch
from
c09dc8c to
769cdc3
Compare
Member
Author
|
Ready for core maintainer review! cc @Cyrilvallez @ArthurZucker |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Cyrilvallez
approved these changes
Mar 3, 2025
Member
Cyrilvallez
left a comment
Cyrilvallez
left a comment
There was a problem hiding this comment.
LGTM! Indeed much better not to silently skip the adapters! 🫠
Rocketknight1
force-pushed
the
pipeline-peft-interaction-fix
branch
from
769cdc3 to
70fb6e2
Compare
Rocketknight1
force-pushed
the
pipeline-peft-interaction-fix
branch
from
70fb6e2 to
fa5696d
Compare
garrett361
pushed a commit
to garrett361/transformers
that referenced
this pull request
Mar 4, 2025
* Fix pipeline-peft interaction * once again you have committed a debug breakpoint * Remove extra testing line * Add a test to check adapter loading * Correct adapter path * make fixup * Remove unnecessary check * Make check a little more stringent
garrett361
pushed a commit
to garrett361/transformers
that referenced
this pull request
Mar 4, 2025
* Fix pipeline-peft interaction * once again you have committed a debug breakpoint * Remove extra testing line * Add a test to check adapter loading * Correct adapter path * make fixup * Remove unnecessary check * Make check a little more stringent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you pass a PEFT adapter checkpoint to
pipeline(), it actually loads the base model without the adapter. The reason is a bug in thepipeline()code, which has to look up the base model repo to get the config/architecture for the model, but accidentally totally clobbers the adapter path when it does.Fixes #36473