Skip to content

Conversation

@threewebcode
Copy link
Contributor

@threewebcode threewebcode commented Mar 4, 2025

What does this PR do?

There are something wrongs with code comments, error messages, docstrings. This change makes them right.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@github-actions github-actions bot marked this pull request as draft March 4, 2025 01:17
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2025

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the Ready for review button (at the bottom of the PR page).

@threewebcode threewebcode marked this pull request as ready for review March 4, 2025 01:18
@threewebcode threewebcode changed the title chore: enhance the message in docstrings chore: enhance messages in docstrings Mar 4, 2025
Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! You can sometimes deduce the nationality of the original author when the precedings adjectives also become plural to match their associateds nouns 😅 🇫🇷

@Rocketknight1 Rocketknight1 merged commit 66f29aa into huggingface:main Mar 4, 2025
8 checks passed
@threewebcode threewebcode deleted the develop branch March 4, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants