-
Notifications
You must be signed in to change notification settings - Fork 31.7k
Refactor some core stuff #36539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor some core stuff #36539
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
LysandreJik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, clean, and understandable! I appreciate the long explanatory docs even for shorter methods that are key
Cyrilvallez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice, very happy to see all the cleanup and the new interface! 🤗
Just added a few nits
Co-authored-by: Lysandre Debut <[email protected]>
Co-authored-by: Lysandre Debut <[email protected]>
What does this PR do?
Update the base model prifx things, and make sure the config diff is aligned with transformers philo: explicit.
Before:
After