fix tiktoken convert to pass AddedToken to Tokenizer #36566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the |
itazap
changed the title
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Mar 6, 2025
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
LGTM, can we check why the fast tests were not failing before (no gguf on the docker?)
shethaadit
approved these changes
Mar 7, 2025
itazap
force-pushed
the
36438_tiktoken_convert
branch
from
78fc6c5 to
84b892d
Compare
itazap
force-pushed
the
36438_tiktoken_convert
branch
from
7cfaf74 to
d7f52c5
Compare
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
May 14, 2025
* pass AddedToken to Tokenizer * ruff * handle dict for special tokens * option: test tokenizer from tiktoken same as fast * ruff * ruff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #36438
Reason for the issue: that a list of tokens is expected, not a dict of tokens / ids, which is what tiktoken's encoding_name_for_model provides. This converter function was designed for more 'behind the scenes' use I guess, but we can make this fix to support it better for direct use.
We don't explicitly test convert_slow_tokenizer, so we can test equivalence for gpt2 (since it's common between tiktoken and transformers)