-
Notifications
You must be signed in to change notification settings - Fork 31.7k
Disable inductor config setter by default #36608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable inductor config setter by default #36608
Conversation
This is hard to debug and should be off by default
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the |
|
If the recommended settings generally work better, would it make sense to document that somewhere and tell users how to enable them? |
I've added a note to the .md file as well. |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
|
note: the failing test seems to be on trunk or at least unrelated, other PRs are also failing with teh same unrelated error: #36610 |
|
looks like 2 HTTPS errors? |
SunMarc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update !
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
This is ready to land @SunMarc @ArthurZucker |
ArthurZucker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for pushing through
* Disable inductor config setter by default This is hard to debug and should be off by default * remove default settings in autoquant too * Add info to torchao.md about recommended settings * satisfying Ruff format Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: --------- Co-authored-by: Marc Sun <[email protected]>
This was requested in the huggingface x pytorch slack by @BenjaminBossan
This setting for Torchao should be disabled by default to avoid side effects (https://github.com/pytorch/ao/blob/24c966cb8931507ef389715bc5f19a11c28b0484/torchao/quantization/utils.py#L574)
torch._inductor.config.coordinate_descent_tuning = True
torch._inductor.config.coordinate_descent_check_all_directions = True
torch._inductor.config.force_fuse_int_mm_with_mul = True
torch._inductor.config.fx_graph_cache = True
torch._inductor.config.triton.unique_kernel_names = True
torch.set_float32_matmul_precision("high")
though the default performance will be worse, these settings can be set manually.
@SunMarc