Skip to content

Conversation

@HDCharles
Copy link
Contributor

@HDCharles HDCharles commented Mar 7, 2025

This was requested in the huggingface x pytorch slack by @BenjaminBossan

This setting for Torchao should be disabled by default to avoid side effects (https://github.com/pytorch/ao/blob/24c966cb8931507ef389715bc5f19a11c28b0484/torchao/quantization/utils.py#L574)

torch._inductor.config.coordinate_descent_tuning = True
torch._inductor.config.coordinate_descent_check_all_directions = True
torch._inductor.config.force_fuse_int_mm_with_mul = True
torch._inductor.config.fx_graph_cache = True
torch._inductor.config.triton.unique_kernel_names = True
torch.set_float32_matmul_precision("high")

though the default performance will be worse, these settings can be set manually.

@SunMarc

This is hard to debug and should be off by default
@github-actions github-actions bot marked this pull request as draft March 7, 2025 17:55
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the Ready for review button (at the bottom of the PR page).

@BenjaminBossan
Copy link
Member

If the recommended settings generally work better, would it make sense to document that somewhere and tell users how to enable them?

@HDCharles HDCharles marked this pull request as ready for review March 7, 2025 18:08
@HDCharles
Copy link
Contributor Author

If the recommended settings generally work better, would it make sense to document that somewhere and tell users how to enable them?

I've added a note to the .md file as well.

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@HDCharles
Copy link
Contributor Author

HDCharles commented Mar 7, 2025

note: the failing test seems to be on trunk or at least unrelated, other PRs are also failing with teh same unrelated error: #36610

@HDCharles
Copy link
Contributor Author

looks like 2 HTTPS errors?

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update !

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@HDCharles
Copy link
Contributor Author

This is ready to land @SunMarc @ArthurZucker

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for pushing through

@ArthurZucker ArthurZucker merged commit 9455543 into huggingface:main Mar 20, 2025
21 checks passed
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
* Disable inductor config setter by default

This is hard to debug and should be off by default

* remove default settings in autoquant too

* Add info to torchao.md about recommended settings

* satisfying Ruff format

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

---------

Co-authored-by: Marc Sun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants