fix: fsdp sharded state dict wont work for save_only_model knob #36627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the |
4 tasks
kmehant
force-pushed
the
bug-fsdp-save
branch
3 times, most recently
from
3d7e6e4 to
3a16920
Compare
Rocketknight1
requested review from
SunMarc and
muellerzr
and removed request for
ArthurZucker and
Rocketknight1
Contributor
Author
|
@SunMarc @muellerzr requesting review on this nit fix. Thanks |
SunMarc
reviewed
Mar 11, 2025
src/transformers/trainer.py
Outdated
Comment on lines
813
to
818
| if ( | ||
| hasattr(self.accelerator.state, "fsdp_plugin") | ||
| and "SHARDED_STATE_DICT" in str(self.accelerator.state.fsdp_plugin.state_dict_type) | ||
| and self.args.save_only_model is True | ||
| ): | ||
| raise ValueError("save_only_model option is not compatible with FSDP state dict type 'SHARDED_STATE_DICT'") |
Member
There was a problem hiding this comment.
let's put that in create_accelerator_and_postprocess function ! There are already some checks that exist there for save_only_model arg
kmehant
force-pushed
the
bug-fsdp-save
branch
5 times, most recently
from
fe111ad to
4a2e33b
Compare
Signed-off-by: Mehant Kammakomati <[email protected]>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This was referenced Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #36626
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@ArthurZucker @Rocketknight1